Fix tests that use temp dirs on Windows#669
Closed
inkychris wants to merge 7 commits intospf13:masterfrom
inkychris:windows-temp-dir-fix
Closed
Fix tests that use temp dirs on Windows#669inkychris wants to merge 7 commits intospf13:masterfrom inkychris:windows-temp-dir-fix
inkychris wants to merge 7 commits intospf13:masterfrom
inkychris:windows-temp-dir-fix
Conversation
…ath.Base for Windows backslashes
Contributor
Author
|
Implemented in #673 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #668.
Tests added in #440 called
os.Clearenv()which on windows causesos.TempDir()to default toC:\Windowsand cause subsequent file permission failures. This has been repaced withos.Unsetenv()for the variables used in those tests.The
TestDirsSearchtest was usingpath.Base()in its assertion which did not account for backslashes used on Windows. This has been replaced withfilepath.Base()which correctly returns the expected value.The
initDirs()method now terminates a test if the temporary root test directory does not exist which should help debug tests that use it ifos.Clearenv()gets used in future tests.