Lookup environment variables instead of checking if the value is empty#429
Closed
sagikazarmark wants to merge 1 commit intospf13:masterfrom
sagikazarmark:lookup_env
Closed
Lookup environment variables instead of checking if the value is empty#429sagikazarmark wants to merge 1 commit intospf13:masterfrom sagikazarmark:lookup_env
sagikazarmark wants to merge 1 commit intospf13:masterfrom
sagikazarmark:lookup_env
Conversation
Empty environment variables are perfectly valid values. Fortunately Go provides a way to check whether an env var is empty or not set. Fixes #317
|
|
tsl0922
reviewed
Jan 16, 2018
tsl0922
left a comment
There was a problem hiding this comment.
I think we need a test case for this.
Collaborator
Author
|
I accidentally deleted the source repository, resubmitted as #440 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty environment variables are perfectly valid values.
Fortunately Go provides a way to check whether an env var
is empty or not set.
Fixes #317