Skip to content

chore(tests,test-*,doc): remove more eof#4

Merged
spencer-tb merged 2 commits into
spencer-tb:chore/remove-eof-from-eestfrom
danceratopz:chore/remove-eof-from-eest-suggestions
Jan 13, 2026
Merged

chore(tests,test-*,doc): remove more eof#4
spencer-tb merged 2 commits into
spencer-tb:chore/remove-eof-from-eestfrom
danceratopz:chore/remove-eof-from-eest-suggestions

Conversation

@danceratopz

Copy link
Copy Markdown

🗒️ Description

Additional suggested cleanup to ethereum#1873:

  • Fixes unused arg errors (not caught by CI we have no ruff at the mo on packages/testing).
  • Removes redundant EOF marker infrastructure, this cleans up test parameter IDs.

I filled the changed tests, and diff'd them with hasher - all good! Only clean test IDs that don't refer to the current EVM as "legacy", e.g.,:

 `tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_eoa_tx_after_set_code[fork_Osaka-tx_type_0-evm_code_type_LEGACY-blockchain_test-different_block]
  ->   
  `tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_eoa_tx_after_set_code[fork_Osaka-tx_type_0-blockchain_test-different_block]`  

Changes

  • Remove unused revert parameter from call_return_code() in helpers.py.
  • Remove unused evm_code_type parameter from Conditional, While, and Switch in generators.py.
  • Remove with_all_evm_code_types marker entirely.
  • Remove evm_code_types() abstract method and implementations from fork classes.
  • Simplify call_opcodes() and create_opcodes() to return List[Opcodes] instead of List[Tuple[Opcodes, EVMCodeType]].
  • Remove evm_code_type from with_all_call_opcodes and with_all_create_opcodes marker argnames.
  • Update tests to remove unused evm_code_type parameters.
  • Update documentation to remove EOF references.

🔗 Related Issues or PRs

Parent:

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.

Cute Animal Picture

image

- Remove unused `revert` parameter from `call_return_code()`.
- Remove unused `evm_code_type` parameter from `Conditional.__new__`.
- Remove unused `evm_code_type` parameter from `While.__new__`.
- Remove unused `evm_code_type` field and parameter from `Switch`.
- Remove unused `EVMCodeType` import from generators.
- Remove `with_all_evm_code_types` marker (EOF is dead).
- Remove `evm_code_types()` abstract method and implementations.
- Simplify `call_opcodes()` and `create_opcodes()` to return `List[Opcodes]`
  instead of `List[Tuple[Opcodes, EVMCodeType]]`.
- Remove `evm_code_type` from `with_all_call_opcodes` and
  `with_all_create_opcodes` marker argnames.
- Update tests to remove unused `evm_code_type` parameters.
- Update documentation to remove EOF references.

This removes the now confusing `evm_code_type_LEGACY` test parameters
from pytest nodeids.
@spencer-tb spencer-tb merged commit 58a6383 into spencer-tb:chore/remove-eof-from-eest Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants