chore(tests,test-*,doc): remove more eof#4
Merged
spencer-tb merged 2 commits intoJan 13, 2026
Merged
Conversation
- Remove unused `revert` parameter from `call_return_code()`. - Remove unused `evm_code_type` parameter from `Conditional.__new__`. - Remove unused `evm_code_type` parameter from `While.__new__`. - Remove unused `evm_code_type` field and parameter from `Switch`. - Remove unused `EVMCodeType` import from generators.
- Remove `with_all_evm_code_types` marker (EOF is dead). - Remove `evm_code_types()` abstract method and implementations. - Simplify `call_opcodes()` and `create_opcodes()` to return `List[Opcodes]` instead of `List[Tuple[Opcodes, EVMCodeType]]`. - Remove `evm_code_type` from `with_all_call_opcodes` and `with_all_create_opcodes` marker argnames. - Update tests to remove unused `evm_code_type` parameters. - Update documentation to remove EOF references. This removes the now confusing `evm_code_type_LEGACY` test parameters from pytest nodeids.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Additional suggested cleanup to ethereum#1873:
I filled the changed tests, and diff'd them with hasher - all good! Only clean test IDs that don't refer to the current EVM as "legacy", e.g.,:
Changes
revertparameter fromcall_return_code()inhelpers.py.evm_code_typeparameter fromConditional,While, andSwitchingenerators.py.with_all_evm_code_typesmarker entirely.evm_code_types()abstract method and implementations from fork classes.call_opcodes()andcreate_opcodes()to returnList[Opcodes]instead ofList[Tuple[Opcodes, EVMCodeType]].evm_code_typefromwith_all_call_opcodesandwith_all_create_opcodesmarker argnames.evm_code_typeparameters.🔗 Related Issues or PRs
Parent:
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture