feat: [junit] #153 Add properties support on test case level for test logger#154
Conversation
|
@timo-reymann thank you. Changes are looking great. I'm curious about the *TestAdapter.cs changes. Apart from the NUnit, the other frameworks should already populate Edit: after reading the changes once more, I believe this might be required for the Trait discoverer scenario. |
| uses: actions/cache@v3 | ||
| with: | ||
| path: ~/.nuget/packages | ||
| key: ${{ runner.os }}-nuget-${{ hashFiles('**/packages.lock.json') }} |
There was a problem hiding this comment.
Since we're not using NuGet lock files, should we use Directory.Packages.props for hash key?
Yes, we can do this separately. Since we'll change this eventually, we can ignore the cache file hash related comment above.
This is good as well. Let's merge this one 🚀 |
|
I checked again with the v4 action and it probably will never work as the running .NET sdk will be always the current LTS; which does not work for some reason with targeting .netcore app 3.1 :/ had similiar problems locally at first and only way around it was to use it explicitly similiar to github actions |
This adds support for adding custom properties to the junit testcase element, based on the framework, requested in #153
This supports:
NUnit.CategoryXUnit.Trait(either directly attached to a method or discovered viaXUnit.TraitDiscoverer)Microsoft.VisualStudio.TestTools.UnitTesting.TestContext.TestPropertyChanges
Brief overview of the changes to areas of the project
GitHub actions
Logger
Testing
JUnit.Xml.TestLogger.XUnit.NetCore.Teststo verify the xUnit discoverer, also combined with traits worksJUnitTestLoggerXUnitAcceptanceTeststo run the added xUnit project