Skip to content

changes Search in SelectionPrompt to accept Space Key as text#1601

Closed
DerReparator wants to merge 1 commit into
spectreconsole:mainfrom
DerReparator:1536-fix-search-of-space-character
Closed

changes Search in SelectionPrompt to accept Space Key as text#1601
DerReparator wants to merge 1 commit into
spectreconsole:mainfrom
DerReparator:1536-fix-search-of-space-character

Conversation

@DerReparator

@DerReparator DerReparator commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

fixes #1536

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

This changes the hotkeys for the single Selection (not the Multi Selection) in such a way that the Space key does not select the option anymore but instead is typed into the search.

If the search is not enabled for the Selection, Space still selects the current option.

Please upvote 👍 this pull request if you are interested in it.

@DerReparator

DerReparator commented Aug 8, 2024 via email

Copy link
Copy Markdown
Contributor Author

@github-actions github-actions Bot added the ⭐ top pull request Top pull request. label Sep 2, 2024
@github-actions github-actions Bot mentioned this pull request Sep 2, 2024
Open
@github-actions github-actions Bot added ⭐ top pull request Top pull request. and removed ⭐ top pull request Top pull request. labels Sep 6, 2024
@mitchdenny mitchdenny mentioned this pull request Aug 18, 2025
Merged
6 tasks
@patriksvensson

patriksvensson commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Hi!

Thanks so much for taking the time to submit this PR.
I really appreciate the contribution!

Unfortunately, I haven’t had the capacity to review this in a timely manner, and since it was opened, the repository has changed significantly. Because of that, this PR is no longer in a state where it can be reviewed or merged as-is. This is not your fault, but mine, and I'm sorry about this.

I’m going to close it for now to help keep things tidy. That said, if you’re still interested in contributing, please feel free to open a new pull request that’s up to date with the current state of the repository, and I’ll be happy to take a look when I can. I'll promise I'll do better this time around.

Thanks again for your work and for your interest in the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tmakluf tmakluf tmakluf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

⭐ top pull request Top pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search doesn't work properly in selection prompts

3 participants

@DerReparator @patriksvensson @tmakluf