Feat/barchart updates#1388
Conversation
|
@microsoft-github-policy-service agree |
patriksvensson
left a comment
There was a problem hiding this comment.
We need to cover the new functionality with some tests and update the documentation for the BarChart. I also think that the Progress bar changes should be moved to its own PR.
Also, we will need you to fill out the PR template as part of the PR. You can find it here: https://raw.githubusercontent.com/spectreconsole/spectre.console/main/.github/pull_request_template.md
|
We will also need to update the documentation so it reflect the new additions. |
|
Hi! Thanks so much for taking the time to submit this PR. Unfortunately, I haven’t had the capacity to review this in a timely manner, and since it was opened, the repository has changed significantly. Because of that, this PR is no longer in a state where it can be reviewed or merged as-is. This is not your fault, but mine, and I'm sorry about this. I’m going to close it for now to help keep things tidy. That said, if you’re still interested in contributing, please feel free to open a new pull request that’s up to date with the current state of the repository, and I’ll be happy to take a look when I can. I'll promise I'll do better this time around. Thanks again for your work and for your interest in the project! |
I'm going to start the process for this PR to make it add more clarity on the issue #1382 raised to see exactly what was changed and to start the conversation
Key points
Added
ValueFormatterfor bar chart based on breakdown chartAdded label color option
I have read the Contribution Guidelines
I have commented on the issue above and discussed the intended changes
A maintainer has signed off on the changes and the issue was assigned to me
All newly added code is adequately covered by tests
All existing tests are still running without errors
The documentation was modified to reflect the changes OR no documentation changes are required.
Please upvote 👍 this pull request if you are interested in it.