Skip to content

Enhance the style of the checkboxes for multi-selection#1244

Merged
patriksvensson merged 2 commits into
spectreconsole:mainfrom
davide-pi:feature/improve-multiselection-checkbox-style
Sep 9, 2024
Merged

Enhance the style of the checkboxes for multi-selection#1244
patriksvensson merged 2 commits into
spectreconsole:mainfrom
davide-pi:feature/improve-multiselection-checkbox-style

Conversation

@davide-pi

@davide-pi davide-pi commented Jun 21, 2023

Copy link
Copy Markdown

Description

Enhance the style of the checkboxes for multi-selection by applying the selected style, if available, to the checkboxes that are currently selected.

Examples

Old or without style specified
image

With multiselection style specified with .HighlightStyle(new Style(Color.Red))
image

Reason

I would like the X on the selected checkboxes to have the same style as the multiselection highlight to avoid any mismatched color combinations


Please upvote 👍 this pull request if you are interested in it.

@davide-pi

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@SypherrDev

Copy link
Copy Markdown

I truly hope this gets merged, it's truly painful for designing that the color isn't matching.

@davide-pi

Copy link
Copy Markdown
Author

Thansk @SypherrDev, I'm waiting for someone review to be able to complete these PR. 😃

@davide-pi

Copy link
Copy Markdown
Author

@patriksvensson aligned also this branch to the last commit in main.
If you find some time to check it I will be grateful 🙇‍♂️

@patriksvensson

Copy link
Copy Markdown
Contributor

@davide-pi Could you perfom a rebase on your branch instead of a merge as per our CONTRIBUTING.md instructions?

…he selected style, if available, to the checkboxes that are currently selected.

# Conflicts:
#	src/Spectre.Console/Prompts/List/ListPromptConstants.cs
@davide-pi

davide-pi commented Sep 9, 2024

Copy link
Copy Markdown
Author

Sure sorry @patriksvensson.

Fixed with the rebase, thanks!

@patriksvensson patriksvensson merged commit a55b802 into spectreconsole:main Sep 9, 2024
@davide-pi davide-pi deleted the feature/improve-multiselection-checkbox-style branch September 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants