1059 Ability to add command line values to remaining arguments if they cannot be set on the settings class#1102
Closed
FrankRay78 wants to merge 1 commit into
spectreconsole:mainfrom
FrankRay78:1059-Ability-to-add-command-line-values-to-remaining-arguments-if-they-cannot-be-set-on-the-settings-class
Closed
1059 Ability to add command line values to remaining arguments if they cannot be set on the settings class#1102FrankRay78 wants to merge 1 commit intospectreconsole:mainfrom FrankRay78:1059-Ability-to-add-command-line-values-to-remaining-arguments-if-they-cannot-be-set-on-the-settings-class
FrankRay78 wants to merge 1 commit into
spectreconsole:mainfrom
FrankRay78:1059-Ability-to-add-command-line-values-to-remaining-arguments-if-they-cannot-be-set-on-the-settings-class
Conversation
This was referenced Dec 8, 2022
Contributor
Author
|
FYI - This PR has been bundled in #1103, should it wish to be reviewed/merged alongside related issues. If so, this PR should be closed with no further action. |
Contributor
Author
|
I'm closing this PR as it's been bundled into #1103 and it's too onerous for me to keep rebasing this, and the other bundled PR's, to keep up with the upstream/main branch as it moves forward with various other commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #1059, 'Ability to add command line flags and their values to remaining arguments if they cannot be set on the settings class'
A configuration setting called ConvertFlagsToRemainingArgumentsIfCannotBeAssigned has been added to the CommandAppSettings interface/class, which determines whether this behaviour has been turned on (defaults to off to ensure backward compatibility). CommandTreeParser checks this setting prior to deciding whether to throw the Flags cannot be set. exception, or alternatively, to add the flag and its value to the remaining arguments collection.
This PR superceeds #1060