203 simple switches end up on remaining list even if parsed properly#1070
Closed
FrankRay78 wants to merge 3 commits into
spectreconsole:mainfrom
FrankRay78:203-Simple-switches-end-up-on-remaining-list-even-if-parsed-properly2
Closed
203 simple switches end up on remaining list even if parsed properly#1070FrankRay78 wants to merge 3 commits intospectreconsole:mainfrom FrankRay78:203-Simple-switches-end-up-on-remaining-list-even-if-parsed-properly2
FrankRay78 wants to merge 3 commits into
spectreconsole:mainfrom
FrankRay78:203-Simple-switches-end-up-on-remaining-list-even-if-parsed-properly2
Conversation
…e duplicates of those (in the more appropriately named) file, CommandAppTests.Remaining.cs
Contributor
Author
|
FYI - This PR has been bundled in #1103, should it wish to be reviewed/merged alongside related issues. If so, this PR should be closed with no further action. |
Contributor
Author
|
I'm closing this PR as it's been bundled into #1103 and it's too onerous for me to keep rebasing this, and the other bundled PR's, to keep up with the upstream/main branch as it moves forward with various other commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fully addresses #203, 'Simple switches end up on "remaining" list even if parsed properly'
It's a one-line change to the CommandTreeParser but code coverage has been increased through 10 additional unit tests covering the change.