Fix mock filtering implementation to ensure it is symmetric with the contract tests#2336
Merged
joelrosario merged 11 commits intomainfrom Mar 11, 2026
Merged
Fix mock filtering implementation to ensure it is symmetric with the contract tests#2336joelrosario merged 11 commits intomainfrom
joelrosario merged 11 commits intomainfrom
Conversation
…es not use a filter anymore
…iminate possibility of loading duplicate example directories
- Fix issue with loadExternalisedExamplesAndListUnloadableExamples - Combining String with list of string
- Should be able to filter in and filter out scenarios using concrete path parameter values
- Add simple test to ensure this doesn't regress again
- stubFilter should also filter inline examples - Add simple tests for the same
…toring example loading logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Ensure symmetry between mock and contract test filtering
Why: The endpoints and example filtering via mock was not consistent with the contract tests. Unlike the contract tests, which filter examples from scenario rows after loading, the mock filtering applied a two-step process to filter scenarios and then examples. Additionally, some filters were not implemented for the examples directly, leading to unexpected runtime exceptions
How: Similar to contract tests, the mock now also filters the example post-load using rows
Checklist: