Skip to content

Fix test example filtering#2330

Merged
joelrosario merged 1 commit intomainfrom
filter-fix
Mar 10, 2026
Merged

Fix test example filtering#2330
joelrosario merged 1 commit intomainfrom
filter-fix

Conversation

@joelrosario
Copy link
Copy Markdown
Contributor

@joelrosario joelrosario commented Mar 10, 2026

What:

Cleaner example filtering for test.

Why:

Previous example filtering would filter the actual examples. The issue with this is that scenarios may be filtered on tokens that do not appear in examples, e.g. tags. If a scenario is filtered out, due to a tag, it's examples will not be filtered out, and will look orphaned, resulting in errors or warnings.

How:

The approach now is to load them first, then filter the scenarios out.

Checklist:

  • Unit Tests
  • Build passing locally
  • Sonar Quality Gate
  • Security scans don't report any vulnerabilities
  • Documentation added/updated (share link)
  • Sample Project added/updated (share link)
  • Demo video (share link)
  • Article on Website (share link)
  • Roadmpap updated (share link)
  • Conference Talk (share link)

@joelrosario
Cleaner example filtering for test. Previous example filtering would …
329995f 
…filter the actual examples. The issue with this is that scenarios may be filtered on tokens that do not appear in examples, e.g. tags. If a scenario is filtered out, due to a tag, it's examples will not be filtered out, and will look orphaned, resulting in in errors or warnings. The approach now is to load them first, then filter the scenarios out.
@joelrosario joelrosario merged commit d4024ae into main Mar 10, 2026
3 checks passed
@joelrosario joelrosario deleted the filter-fix branch March 10, 2026 12:46
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026

Summary

Line coverage Branch coverage

Assembly Line coverage Branch coverage
application 63.4% 55.5%
application/backwardCompatibility 79.5% 65.1%
application/mcp 84.7% 76.9%
application/validate 1.2% 2.5%
io/specmatic/conversions 93.3% 78.5%
io/specmatic/conversions/lenient 97.6% 77.4%
io/specmatic/core 81.5% 62.9%
io/specmatic/core/azure 0% 0%
io/specmatic/core/config 61.6% 39.4%
io/specmatic/core/config/v1 97.9% 25%
io/specmatic/core/config/v2 91.9% 78.8%
io/specmatic/core/config/v3 56.7% 30.1%
io/specmatic/core/config/v3/components 78.9% 40%
io/specmatic/core/config/v3/components/runOptions 75.4% 47.5%
io/specmatic/core/config/v3/components/services 89.4% 59.6%
io/specmatic/core/config/v3/components/settings 100% 63.8%
io/specmatic/core/config/v3/components/sources 83.8% 61.5%
io/specmatic/core/config/v3/specmatic 57.6% 25%
io/specmatic/core/discriminator 52.6% 50%
io/specmatic/core/examples/module 45.7% 28.9%
io/specmatic/core/examples/server 73.8% 36.8%
io/specmatic/core/filters 83.1% 72.1%
io/specmatic/core/fuzzy 97.3% 93.8%
io/specmatic/core/git 9% 10.8%
io/specmatic/core/jsonoperator 67.8% 69.5%
io/specmatic/core/jsonoperator/value 86.2% 74.4%
io/specmatic/core/lifecycle 0% ****
io/specmatic/core/log 76.2% 62.3%
io/specmatic/core/matchers 79.2% 64.5%
io/specmatic/core/overlay 87.3% 58.8%
io/specmatic/core/pattern 87.3% 76.6%
io/specmatic/core/pattern/config 100% ****
io/specmatic/core/pattern/regex 94.5% 87.5%
io/specmatic/core/report 97.5% 91.6%
io/specmatic/core/route/modules 95% 87.5%
io/specmatic/core/utilities 69.5% 61%
io/specmatic/core/value 82.4% 69.2%
io/specmatic/core/wsdl/parser 81.4% 41%
io/specmatic/core/wsdl/parser/message 90% 72%
io/specmatic/core/wsdl/parser/operation 100% 100%
io/specmatic/core/wsdl/payload 81.1% 50%
io/specmatic/junit5/support 0% ****
io/specmatic/loader 84.6% 53.5%
io/specmatic/mcp/constants 0% ****
io/specmatic/mcp/report 0% 0%
io/specmatic/mcp/test 0% 0%
io/specmatic/mcp/test/client 0% 0%
io/specmatic/mcp/test/client/model 0% 0%
io/specmatic/mock 61.4% 56.5%
io/specmatic/proxy 67% 52%
io/specmatic/specmatic/core 100% ****
io/specmatic/specmatic/executable 100% ****
io/specmatic/specmatic/mcp 0% ****
io/specmatic/stub 78.6% 68%
io/specmatic/stub/listener 100% 100%
io/specmatic/stub/report 100% 77%
io/specmatic/test 73.6% 63.2%
io/specmatic/test/asserts 95.2% 86.6%
io/specmatic/test/handlers 89.7% 63.3%
io/specmatic/test/listeners 86.4% 53.2%
io/specmatic/test/reports 60% 33.3%
io/specmatic/test/reports/coverage 97.2% 54.9%
io/specmatic/test/reports/coverage/console 90.2% 84%
io/specmatic/test/reports/coverage/html 0% 0%
io/specmatic/test/reports/renderers 21.8% 24.1%
io/specmatic/test/utils 92.3% 80%

@joelrosario joelrosario mentioned this pull request Mar 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joelrosario