Optimize HttpStub response generation and example load code path#2308
Merged
joelrosario merged 11 commits intomainfrom Mar 2, 2026
Merged
Optimize HttpStub response generation and example load code path#2308joelrosario merged 11 commits intomainfrom
joelrosario merged 11 commits intomainfrom
Conversation
- Convert to using sequence when possible - Operate on a subset of scenarios matching method and path - applyStubFallbackRequestFilters on scenarios instead of result
Summary
|
- example.resolveDataSubstitutions() returns just a list of self
- Use EarlyResult.kt for clearer intent - Remove selectMatchingStubBasedOnAcceptPriority as it servers no purpose at the moment
6d22d03 to
19c0578
Compare
- Attribute selection was only used for non-partial examples
…improve coverage fo modified code paths
…n strict mode and add tests for response matching scenarios
joelrosario
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Optimize HttpStub response generation and example load code path
Why: The previous flow evaluated/mapped more scenarios than necessary before determining the result
How:
Checklist: