Fix HttpStub issues with generative enabled#2303
Merged
joelrosario merged 4 commits intomainfrom Feb 26, 2026
Merged
Conversation
Summary
|
- Fix strict generative always being true even when not set - Fis generative strict generative not working with no examples - Add simple tests for the same
0b28a20 to
73bb777
Compare
- Use the 400Scenario and its feature instead of fakeResponse - As fakeResponse will always be null on this code path - Fix HttpLogMessage.toResult to consider result - Add simple test for the same
joelrosario
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fix HttpStub Issues with generative enabled, with and without strictMode
How:
MockEventswhen generative is enabledChecklist: