Fail parsing if the required prefix isn't present for IDs#275
Merged
Fail parsing if the required prefix isn't present for IDs#275
Conversation
If the `SPDXRef-` or `DocumentRef-` prefix isn't present in an ID, then fail parsing. In addition, if stripping the prefix leaves an empty ID then also fail. This is in line with the spec: https://spdx.github.io/spdx-spec/v2.3/document-creation-information/#6.3 https://spdx.github.io/spdx-spec/v2.3/package-information/#7.2 https://spdx.github.io/spdx-spec/v2.3/file-information/#8.2 See #274 for more details about the issue being fixed. Signed-off-by: Andrew Wyeth <awyeth@google.com>
If the `SPDXRef-` or `DocumentRef-` prefix isn't present in an ID, then fail parsing. In addition, if stripping the prefix leaves an empty ID then also fail. This is in line with the spec: https://spdx.github.io/spdx-spec/v2.3/document-creation-information/#6.3 https://spdx.github.io/spdx-spec/v2.3/package-information/#7.2 https://spdx.github.io/spdx-spec/v2.3/file-information/#8.2 See #274 for more details about the issue being fixed. Signed-off-by: Andrew Wyeth <awyeth@google.com>
This version matches the version in go.mod. Signed-off-by: Andrew Wyeth <awyeth@google.com>
lumjjb
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
SPDXRef-orDocumentRef-prefix isn't present in an ID, then fail parsing. In addition, if stripping the prefix leaves an empty ID then also fail.This is in line with the spec:
https://spdx.github.io/spdx-spec/v2.3/document-creation-information/#6.3
https://spdx.github.io/spdx-spec/v2.3/package-information/#7.2
https://spdx.github.io/spdx-spec/v2.3/file-information/#8.2
See #274 for more details about the issue being fixed.