Provide a clearer error when using an invalid Originator#246
Merged
Provide a clearer error when using an invalid Originator#246
Conversation
Fixes spdx#245 Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
fd4b9bb to
32f05be
Compare
Contributor
Author
|
With this change, the snippet in #245 will still fail but not with a JSON syntax error but a more useful error. |
kzantow
approved these changes
Jun 16, 2024
Collaborator
kzantow
left a comment
There was a problem hiding this comment.
LGTM, thanks @LaurentGoderre !
cuixq
referenced
this pull request
in google/osv-scanner
Jul 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/spdx/tools-golang](https://togithub.com/spdx/tools-golang) | `v0.5.4` -> `v0.5.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>spdx/tools-golang (github.com/spdx/tools-golang)</summary> ### [`v0.5.5`](https://togithub.com/spdx/tools-golang/releases/tag/v0.5.5) [Compare Source](https://togithub.com/spdx/tools-golang/compare/v0.5.4...v0.5.5) #### What's Changed - fix: properly normalize Windows paths, add windows test runner by [@​kzantow](https://togithub.com/kzantow) in [https://github.com/spdx/tools-golang/pull/242](https://togithub.com/spdx/tools-golang/pull/242) - fix: panic if JSON relationship array contains null by [@​kzantow](https://togithub.com/kzantow) in [https://github.com/spdx/tools-golang/pull/239](https://togithub.com/spdx/tools-golang/pull/239) - chore: provide a clearer error when using an invalid Originator by [@​LaurentGoderre](https://togithub.com/LaurentGoderre) in [https://github.com/spdx/tools-golang/pull/246](https://togithub.com/spdx/tools-golang/pull/246) #### New Contributors - [@​LaurentGoderre](https://togithub.com/LaurentGoderre) made their first contribution in [https://github.com/spdx/tools-golang/pull/246](https://togithub.com/spdx/tools-golang/pull/246) **Full Changelog**: spdx/tools-golang@v0.5.4...v0.5.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: Xueqin Cui <72771658+cuixq@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245