Skip to content

Add gallery feature#392

Merged
mgeier merged 3 commits intospatialaudio:masterfrom
mgeier:gallery
Mar 30, 2020
Merged

Add gallery feature#392
mgeier merged 3 commits intospatialaudio:masterfrom
mgeier:gallery

Conversation

@mgeier
Copy link
Copy Markdown
Member

@mgeier mgeier commented Jan 26, 2020

See #254.

A few minor things are still missing, but most of it should be working already.

Loading the styles from Sphinx-Gallery should become simpler with this: sphinx-gallery/sphinx-gallery#601.

Rendered HTML: https://130-210404706-gh.circle-artifacts.com/0/html/subdir/gallery.html

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Feb 17, 2020

Hello @mgeier! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:28: W292 no newline at end of file

Comment last updated at 2020-03-28 09:10:34 UTC

@mgeier
Copy link
Copy Markdown
Member Author

mgeier commented Feb 17, 2020

I've asked at the Sphinx mailing list (https://groups.google.com/d/topic/sphinx-dev/Jh42WXO-mHo/discussion) and have added 7f2c842 based on the answer I got there.

@mgeier
Copy link
Copy Markdown
Member Author

mgeier commented Feb 17, 2020

@mgeier
Copy link
Copy Markdown
Member Author

mgeier commented Feb 25, 2020

@mgeier
Copy link
Copy Markdown
Member Author

mgeier commented Mar 27, 2020

@mgeier mgeier marked this pull request as ready for review March 27, 2020 20:51
@maartenbreddels
Copy link
Copy Markdown

Hi Matthias,

this seems to work really well!
I plan to manually take screenshots/screen captures of ipyvolume. I'd like to thus manually add the thumbnail. If I do this in conf.py, I cannot add a tooltip. Would it be an idea to add this as well, .e.g:

nbsphinx_thumbnails = {
    'examples/scatter': 'examples/scatter.png',
    'examples/volshow': {'filename': 'examples/scatter.png', 'tooltip': 'Basic volume,
}

Even better would be if we could auto generate a tooltip from the 1st markdown cell, the first sentence after the first H1 (i guess that is what sphinx-gallery does).

cheers,

Maarten

@mgeier mgeier merged commit e915fc5 into spatialaudio:master Mar 30, 2020
@mgeier mgeier deleted the gallery branch March 30, 2020 11:14
@mgeier
Copy link
Copy Markdown
Member Author

mgeier commented Mar 30, 2020

Thanks @maartenbreddels for testing this!

I've merged this in order for other people to be able to make PRs with further improvements.

I've moved your above comment to a new issue: #421.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants