fix: handle the case where GC runs during fork safety checks#592
Merged
Conversation
If GC runs between the check for `db.weakref_alive?` and `db.close`
then an exception will be raised:
Invalid Reference - probably recycled (WeakRef::RefError)
In this case, let's just swallow the error and keep going, since the
database object isn't in use and was GCed.
Member
Author
|
@tenderlove or @byroot can I ask for a quick review of this? I considered using ObjectSpace::WeakMap because its foreach has a GC guard on both key and value; but it doesn't have a |
Contributor
|
Yeah, the missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If GC runs between the check for
db.weakref_alive?anddb.closethen an exception will be raised:I personally saw this error when running a Rails app test suite in parallel, so while it's rare it does happen.
In this case, let's just swallow the error and keep going, since the database object isn't in use and was GCed.