Skip to content

Preserve XML whitespace better when signing appcast feed#2840

Merged
zorgiepoo merged 1 commit into2.xfrom
push-lxwwlknrzorx
Jan 12, 2026
Merged

Preserve XML whitespace better when signing appcast feed#2840
zorgiepoo merged 1 commit into2.xfrom
push-lxwwlknrzorx

Conversation

@zorgiepoo
Copy link
Copy Markdown
Member

@zorgiepoo zorgiepoo commented Jan 12, 2026

We don't force pretty print when writing new XML data now when we insert a signing warning. This may mean the signing warning prefix may start on the same line as the first XML element, but I think this is alright since the rest of the warning starts on its own line.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested signing XML file with inconsistent whitespace structure and another XML file with standard pretty printing using sign_update.

macOS version tested: 26.2 (25C56)

We don't force pretty print when writing new XML data now when we insert a signing warning. This may mean the signing warning prefix may start on the same line as the first XML element, but I think this is alright since the rest of the warning starts on its own line.
@zorgiepoo zorgiepoo added this to the 2.9.0 milestone Jan 12, 2026
@zorgiepoo zorgiepoo merged commit 596b6b0 into 2.x Jan 12, 2026
2 checks passed
@zorgiepoo zorgiepoo deleted the push-lxwwlknrzorx branch January 12, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant