Find non-canonical Sparkle.framework locations in generate_appcast#2833
Merged
Find non-canonical Sparkle.framework locations in generate_appcast#2833
Conversation
If Sparkle.framework isn't in Contents/Frameworks/ then we do a deep scan in the app bundle (but ignore Contents/Resources/). Sparkle may be placed in a plug-in or other parent framework. Also remove legacy SparkleCore lookup which is no longer needed.
d1b9d51 to
d97af09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Sparkle.framework isn't in Contents/Frameworks/ then we do a deep scan in the app bundle (but ignore Contents/Resources/). Sparkle may be placed in a plug-in or other parent framework.
Also remove legacy SparkleCore lookup which is no longer needed.
Fixes #2832
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
Tested generate_appcast on app bundle with non-standard Sparkle.framework location. Tested generate_appcast on standard bundles as well.
macOS version tested: 26.2 (25C56)