Remove sparkle-cli (sparkle.app) from binary distribution#2826
Merged
Conversation
|
Unfortunately we relied on the external sparkle binary for updating our macos cli (cpp). Solved by installing xcode on our runners and building from source. Do you recommend that we now build this target ourselves instead of relying on a brew tap? |
Member
Author
|
Recommendations are what is described in the description of this PR + https://sparkle-project.org/documentation/sparkle-cli/ , namely to build sparkle-cli with a custom bundle identifier (not something we can distribute ourselves) so you don't clash with other folks using the tool, or to use Sparkle.framework directly if you are also distributing an app that also uses Sparkle for updating itself (thereby avoiding redundancy of bundling sparkle twice). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External updater software usually (and often should) use
SPUUpdaterdirectly. sparkle-cli is a show case for this. Although the utility app is useful and software may want to rely on it, I think if they want to do that, they should also build/deploy with a customPRODUCT_BUNDLE_IDENTIFIERthat doesn't clash other client's usages.Note this app is already not in the SPM distribution.
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
Tested
make releaselocally and verified sparkle.app is not in there.macOS version tested: 26.2 (25C56)