Skip to content

Workaround a corner case in which the bundle path of a running application contains Contents/MacOS/Executable#2747

Merged
zorgiepoo merged 4 commits into2.xfrom
bundle-path-wrapper-fix
Jul 26, 2025
Merged

Workaround a corner case in which the bundle path of a running application contains Contents/MacOS/Executable#2747
zorgiepoo merged 4 commits into2.xfrom
bundle-path-wrapper-fix

Conversation

@zorgiepoo
Copy link
Copy Markdown
Member

@zorgiepoo zorgiepoo commented Jul 26, 2025

Continuation of #2726 with minor changes (skipping workaround for < macOS 26, performing IO check last for workaround, and unused variable read analyzer fix).

Fixes #2725

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested via debugger correct paths were taken when app bundle is in Contents/MacOS/ (temporarily commented out detection that bundle is not a directory because I don't have such a concrete test case). Ensured output path is correct.

macOS version tested: 15.5 (24F74)

jeremyhu and others added 3 commits June 25, 2025 22:20
… bundle path of a running application contains Contents/MacOS/Executable

Fixed: #2725
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Also perform IO directory check as last part of the workaround.
@zorgiepoo zorgiepoo added this to the 2.8 milestone Jul 26, 2025
@zorgiepoo zorgiepoo merged commit 2cfb1e6 into 2.x Jul 26, 2025
2 checks passed
@zorgiepoo zorgiepoo deleted the bundle-path-wrapper-fix branch July 26, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sparkle does not restart app after update completes (sandboxed app with SUEnableInstallerLauncherService=true)

2 participants