Improve retrieval of main app icon for authorization dialog#2743
Merged
Improve retrieval of main app icon for authorization dialog#2743
Conversation
This is pretty slow unfortunately although code is simpler
This should fix an Updater crash on older OS's (tested on 10.14).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use NSWorkspace to retrieve the main bundle's app icon (the bundle that is doing the updating) for authorization prompts only when Installer Launcher XPC Service is enabled. When this service is disabled, we let the authorization prompt just use the default app icon. This change also removes some no longer needed code (SUBundleIcon).
This will complete tasks for #2738
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
Tested authorization dialog in test app when installer launcher service is enabled and disabled.
macOS version tested:
10.14.6 VM
10.15 VM
15.5 (24F74)
26.0 beta 3 (25A5306g)