Add support for relative URLs for delta updates#2741
Merged
zorgiepoo merged 1 commit intosparkle-project:2.xfrom Jul 12, 2025
dumbmoron:delta-relative-urls
Merged
Add support for relative URLs for delta updates#2741zorgiepoo merged 1 commit intosparkle-project:2.xfrom dumbmoron:delta-relative-urls
zorgiepoo merged 1 commit intosparkle-project:2.xfrom
dumbmoron:delta-relative-urls
Conversation
Member
|
Thank you. Good find and fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative URL support for appcasts was added in #1617, but
relativeToURLwas not passed down by the constructor used to create delta appcast items, meaning when the updater tried to download a delta from a relative path, it resulted in the following error being logged:This PR fixes it so that deltas can also have relative URLs.
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
See unit test update. Pipeline without the change here to show that the problem did exist, and was resolved by this change.
macOS version tested: 26.0 and 16.4