Skip to content

Add support for relative URLs for delta updates#2741

Merged
zorgiepoo merged 1 commit intosparkle-project:2.xfrom
dumbmoron:delta-relative-urls
Jul 12, 2025
Merged

Add support for relative URLs for delta updates#2741
zorgiepoo merged 1 commit intosparkle-project:2.xfrom
dumbmoron:delta-relative-urls

Conversation

@dumbmoron
Copy link
Copy Markdown
Contributor

@dumbmoron dumbmoron commented Jul 11, 2025

Relative URL support for appcasts was added in #1617, but relativeToURL was not passed down by the constructor used to create delta appcast items, meaning when the updater tried to download a delta from a relative path, it resulted in the following error being logged:

Failed to download delta update. Falling back to regular update...
Error: An error occurred while downloading the update. Please try again later. (null) (URL assets/<snip>.delta)
Error: unsupported URL (null) (URL assets/<snip>.delta)

This PR fixes it so that deltas can also have relative URLs.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

See unit test update. Pipeline without the change here to show that the problem did exist, and was resolved by this change.

macOS version tested: 26.0 and 16.4

@dumbmoron dumbmoron changed the title Add support for relative urls for delta updates Add support for relative URLs for delta updates Jul 11, 2025
@zorgiepoo
Copy link
Copy Markdown
Member

Thank you. Good find and fix.

@zorgiepoo zorgiepoo added this to the 2.8 milestone Jul 12, 2025
@zorgiepoo zorgiepoo merged commit 21e3439 into sparkle-project:2.x Jul 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants