Skip to content

Synchronize updater settings with user defaults#2728

Merged
zorgiepoo merged 15 commits into2.xfrom
fix-automatic-download-updates-checkbox
Jun 17, 2025
Merged

Synchronize updater settings with user defaults#2728
zorgiepoo merged 15 commits into2.xfrom
fix-automatic-download-updates-checkbox

Conversation

@zorgiepoo
Copy link
Copy Markdown
Member

@zorgiepoo zorgiepoo commented May 22, 2025

Synchronize updater settings with user defaults so multiple components in an app can better synchronize state -- like the automatically downloads/installs update in the release notes.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)
  • Tested changing automatically download updates checkbox synchronizes between release notes window and test app window
  • Tested user default changes from CLI synchronize with UI in Sparkle (e.g. automatically downloads updates and updates check interval)
  • Tested updating another bundle (by modifying test app) re-synchronizes updater settings after successful update installation
  • Tested using KVO on SPUUpdater properties fires notifications on changes to properties as expected

macOS version tested: 15.5 (24F74)
macOS 10.14 VM
macOS 26 Beta 1

Unless the user opted into automatic download updates and triggered a user default change, the automatic updates checkbox in the update alert window may not reflect the true state.
@zorgiepoo zorgiepoo added this to the 2.7.1 milestone May 22, 2025
@zorgiepoo zorgiepoo modified the milestones: 2.7.1, 2.8 Jun 13, 2025
@zorgiepoo zorgiepoo changed the title Fix automatic updates checkbox not being on if set only in Info.plist Synchronize updater settings with user defaults Jun 13, 2025
@zorgiepoo zorgiepoo merged commit 5f9ee13 into 2.x Jun 17, 2025
2 checks passed
@zorgiepoo zorgiepoo deleted the fix-automatic-download-updates-checkbox branch June 17, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant