Rework the logic for avoiding re-sending the system profile more frequently than once a week#2720
Merged
zorgiepoo merged 1 commit intosparkle-project:2.xfrom Apr 29, 2025
Merged
Conversation
…uently than once a week, so that it will not use a potentially problematic binary compare operation. Fixes sparkle-project#278.
Member
|
Thanks. Did you actually see Sparkle re-send the system profile data more frequently than once a week from the original reporter's claim and it being caused by this, or did you just feel like improving this? That will impact how important I find this change and what release to put it in. |
Contributor
Author
|
I did not see the behavior, and couldn't reproduce it. So, low priority. I just happened to be scrolling through Sparkle bugs and got curious what the oldest one was ;) By the time I had played around with it trying to reproduce, I thought I might as well submit a PR. |
Member
|
Gotcha. Works well over here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the logic for avoiding re-sending the system profile more frequently than once a week, so that it will not use a potentially problematic binary compare operation.
Fixes #278
Testing
I tested and verified my change by using one or multiple of these methods:
macOS version tested: macOS 15.4.1 (24E263)