Make -[SPUUserDriver showUpdateInFocus] optional#2717
Merged
Conversation
When this method is not implemented, the updater assumes already presented updates cannot be brought in utmost focus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this method is not implemented, the updater assumes already presented updates cannot be brought in utmost focus again.
Fixes #2704
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
Tested not implementing showUpdateInFocus in standard user driver with test app, and keeping it implemented.
Tested update notice and permission prompt, and not being able to check for updates when showUpdateInFocus is not implemented.
Tested update notice and permission prompt, and not being able to check for updates when showUpdateInFocus is not implemented and canCheckForUpdates is not checked (with appropriate error message logged).
macOS version tested: 15.4 (24E248)