Fixed bug in spack env due to missing argument.#5280
Merged
alalazo merged 2 commits intospack:developfrom Sep 5, 2017
Merged
Conversation
This command broke after spack#5109. It was using the default value for the "dirty" argument in `setup_package`. Now it adopts the same logic as in `spack install`. Trivial unit test included.
adamjstewart
reviewed
Sep 4, 2017
| ]) | ||
| @pytest.mark.usefixtures('config') | ||
| def test_it_just_runs(pkg): | ||
| info(pkg) |
Member
There was a problem hiding this comment.
It shouldn't be hard to get 100% coverage on this one. Have an example with and without --, an example with multiple specs that's expected to crash, and an example with no command.
Member
|
There is a small issue. The help message is confusing: The 'env' command doesn't install anything. |
Member
Author
|
@skosukhin You're completely right. I'll fix that asap. |
Member
Author
|
@adamjstewart Fine with you to merge? |
Member
|
Yeah, it's not 100%, but it's a lot better than it was before. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command broke after #5109. It was using the default value for the
dirtyargument insetup_package. Now it adopts the same logic as inspack install. Trivial unit test included.