Merged
Conversation
…on, and I accidentally narrowed it to subclasses of PythonPackage
tgamblin
previously approved these changes
Jun 5, 2025
becker33
requested changes
Jun 6, 2025
var/spack/test_repos/spack_repo/builtin_mock/packages/py_extension1/package.py
Outdated
Show resolved
Hide resolved
becker33
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50827
#50616 moved some logic that connects external python extensions to an instance of python; it attempted to do this in a way that matched prior behavior exactly but accidentally applied this for
PythonPackageinstead ofPythonExtension(a superclass of the former) which meant that some packages that this applied to before (e.g.py-pip) were now omitted.Updates the test