Skip to content

Forbid using env: as a top level environment attribute#38199

Merged
becker33 merged 3 commits intospack:developfrom
alalazo:maintainers/remove_env_attribute
Jun 8, 2023
Merged

Forbid using env: as a top level environment attribute#38199
becker33 merged 3 commits intospack:developfrom
alalazo:maintainers/remove_env_attribute

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Jun 6, 2023

Using env: as a top-level environment attribute was deprecated in v0.20, and is now removed in this PR.

@spackbot-app spackbot-app bot added commands core PR affects Spack core functionality environments tests General test capability(ies) labels Jun 6, 2023
@alalazo alalazo added the removal A deprecated feature got removed label Jun 6, 2023
@alalazo alalazo added this to the v0.21.0 milestone Jun 6, 2023
@alalazo alalazo force-pushed the maintainers/remove_env_attribute branch from adf1299 to 4cdd654 Compare June 6, 2023 15:48
@alalazo alalazo removed this from the v0.21.0 milestone Jun 7, 2023
@becker33 becker33 enabled auto-merge (squash) June 8, 2023 16:22
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Jun 8, 2023

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jun 8, 2023

I've started that pipeline for you!

@becker33 becker33 merged commit ddfc43b into spack:develop Jun 8, 2023
@alalazo alalazo deleted the maintainers/remove_env_attribute branch June 8, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands core PR affects Spack core functionality environments removal A deprecated feature got removed tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants