Remove "setup_environment" and "setup_dependent_environment"#29463
Merged
sethrj merged 1 commit intospack:developfrom Mar 13, 2022
Merged
Remove "setup_environment" and "setup_dependent_environment"#29463sethrj merged 1 commit intospack:developfrom
sethrj merged 1 commit intospack:developfrom
Conversation
fixes spack#29446 The new setup_*_environment functions have been falling back to calling the old functions and warn the user since spack#11115. This commit removes the fallback behavior and any use of: - setup_environment - setup_dependent_environment in the codebase
|
@rogerpearce can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
sethrj
approved these changes
Mar 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29446
The new
setup_*_environmentfunctions have been falling back to calling the old functions and warn the user since #11115.This commit removes the fallback behavior and any use of:
setup_environmentsetup_dependent_environmentin the code base.