Refactor bootstrap of "spack style" dependencies#27485
Merged
haampie merged 3 commits intospack:developfrom Nov 18, 2021
Merged
Refactor bootstrap of "spack style" dependencies#27485haampie merged 3 commits intospack:developfrom
haampie merged 3 commits intospack:developfrom
Conversation
haampie
reviewed
Nov 17, 2021
haampie
reviewed
Nov 17, 2021
alalazo
commented
Nov 17, 2021
Remove the "get_executable" function from the spack.bootstrap module. Now "flake8", "isort", "mypy" and "black" wwill use the same bootstrapping method as GnuPG.
c7740e0 to
dabf285
Compare
haampie
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications:
spack.bootstrap.get_executablein favor ofspack.bootstrap.ensure_executables_in_path_or_raiseso that executables are always bootstrapped using a single code path.