Skip to content

Fix MacOS build tests#17542

Merged
ax3l merged 3 commits intospack:developfrom
alalazo:fixes/macos_builds_nightly
Jul 21, 2020
Merged

Fix MacOS build tests#17542
ax3l merged 3 commits intospack:developfrom
alalazo:fixes/macos_builds_nightly

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Jul 15, 2020

Modifications:

  • Run on PR that modify the YAML file of the workflow
  • Don't clone Spack, since we are in the Spack repo now
  • Added a workaround for a bug in compiler detection
  • Fix builds in the nightly MacOS tests

@alalazo alalazo added macOS tests General test capability(ies) maintainers ci Issues related to Continuous Integration labels Jul 15, 2020
@alalazo alalazo force-pushed the fixes/macos_builds_nightly branch 2 times, most recently from 9351857 to e7733d2 Compare July 15, 2020 08:05
@ax3l
Copy link
Copy Markdown
Member

ax3l commented Jul 15, 2020

macOS with Spack seems to have a wide range of current problems when I look at the checks: bzip2 does not build with apple-clang, openblas broke again, zstd, potentially more.

- Run on PR that modify the YAML file of the workflow
- Don't clone Spack, since we are in the Spack repo now
@alalazo alalazo force-pushed the fixes/macos_builds_nightly branch 2 times, most recently from 3f90de8 to 369cfe2 Compare July 18, 2020 05:07
@alalazo alalazo force-pushed the fixes/macos_builds_nightly branch from 507dc80 to a672bf7 Compare July 18, 2020 07:00
@alalazo alalazo marked this pull request as ready for review July 18, 2020 19:16
@alalazo alalazo requested review from ax3l and tgamblin July 18, 2020 19:16
Comment on lines +5 to +18
# TODO: remove this explicit setting once apple-clang detection is fixed
cat <<EOF > etc/spack/compilers.yaml
compilers:
- compiler:
spec: apple-clang@11.0.3
paths:
cc: /usr/bin/clang
cxx: /usr/bin/clang++
f77: /usr/local/bin/gfortran-9
fc: /usr/local/bin/gfortran-9
modules: []
operating_system: catalina
target: x86_64
EOF
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgamblin I'm working around the compiler detection issue by setting it explicitly. This is meant to be removed and substituted with:

$ spack compiler find

as soon as we have a fix for that.

Copy link
Copy Markdown
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ✨ thank you so much!

@ax3l ax3l merged commit ab32799 into spack:develop Jul 21, 2020
@alalazo alalazo deleted the fixes/macos_builds_nightly branch July 21, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Issues related to Continuous Integration macOS maintainers tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants