otf2: fix NameError: name spack_cc is not defined when installing fr…#14361
otf2: fix NameError: name spack_cc is not defined when installing fr…#14361eugeneswalker wants to merge 1 commit intospack:developfrom
NameError: name spack_cc is not defined when installing fr…#14361Conversation
|
Not that I know of, unless it is needed for module generation somehow. |
@adamjstewart Nope. I think you are referring to something that we tried in #13557 and left out in the end because of backward compatibility concerns. This seems more a case similar to the ones solved by #11084 @eugeneswalker Can you check if that PR solves your issue? |
|
@alalazo @michaelkuhn @adamjstewart Yes, I was able to install otf2 from buildcache wo/ errors using #11084 . Thank you. Do you expect this to be merged soon? |
I'll try to prioritize reviewing it, even though I'm quite busy with 0.14.0 at the moment 😬 |
@alalazo This is not an urgent concern for my team right now. It will be nice to have, but not as nice as Spack 0.14, just FYI. Thank you 👍 |
|
Closing in favor of #11084 |
Installation of
otf2from build cache fails because of:which is referenced in
configure_args()section of the otf2 package. I'm not sure this is the best way to address it, here I'm substituting the logic from I was trying to substitute how spack_cc et. al. get defined in https://github.com/spack/spack/blob/develop/lib/spack/spack/build_environment.py#L460