Fix broken links to cosmetic path in mirrors#14093
Closed
alalazo wants to merge 1 commit intospack:developfrom
Closed
Fix broken links to cosmetic path in mirrors#14093alalazo wants to merge 1 commit intospack:developfrom
alalazo wants to merge 1 commit intospack:developfrom
Conversation
fixes spack#14067 In spack#13789 an absolute path was erroneously substituted with a relative one, causing broken links in mirrors. This PR restores the absolute path and adds a unit test to avoid regressions.
Member
Author
|
@iarspider Can you confirm this solves the issue also for you? |
Contributor
|
Yes, it fixes the issue. |
Member
Member
Author
|
@scheibelp I missed #13908, sorry. I'll give it a review tomorrow. Do you want to grab the unit test from this one? |
Member
Thanks, yes I added it to d7e6557 (with some tweaks) |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14067
In #13789 an absolute path was erroneously substituted with a relative one, causing broken links in mirrors. This PR restores the absolute path and adds a unit test to avoid regressions.