Skip to content

Handle external perl#13903

Merged
alalazo merged 2 commits intospack:developfrom
scheibelp:bugfix/perl-bin-external
Nov 29, 2019
Merged

Handle external perl#13903
alalazo merged 2 commits intospack:developfrom
scheibelp:bugfix/perl-bin-external

Conversation

@scheibelp
Copy link
Copy Markdown
Member

@scheibelp scheibelp commented Nov 26, 2019 •
edited by alalazo
Loading

Fixes #13792
Fixes #13930

99dfff4 updated perl to add perl's bin/ directory to PATH but does not filter it when it is a system path. This removes that logic from the perl package because adding bin for a given package is already handled in Spack core (and it includes filtering logic for system dirs)

@scheibelp
dont add perl bin directory to PATH when setting up env (this is alre…
564b19d 
…ady handled by spack core in a way that omits system dirs); also consolidate repeated logic between build/run env setup.
@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Nov 26, 2019 •
edited
Loading

Why do we need to set PATH at all? Aren't all prefix.bin automatically added to the PATH?

@scheibelp
Copy link
Copy Markdown
Member Author

scheibelp commented Nov 26, 2019

Why do we need to set PATH at all? Aren't all prefix.bin automatically added to the PATH?

They are: I don't see special considerations for doing this separately for perl (adding modules to PATH appears to date back to #3614). So I think that should also be addressed here too.

@scheibelp
the bin/ dir of each dependency is already added to PATH in Spack cor…
65106c5 
…e, so there is no need to do this in the Perl package
@scheibelp scheibelp requested a review from becker33 November 26, 2019 23:52
@mwkrentel
Copy link
Copy Markdown
Member

mwkrentel commented Nov 26, 2019

I tried this and yes, it does fix the problem I reported in #13792.

Of course, you may want to check with @becker33, in case there was
some specific reason for treating perl specially.

@mwkrentel mwkrentel mentioned this pull request Nov 27, 2019
Closed
@adamjstewart adamjstewart mentioned this pull request Nov 28, 2019
Closed
@alalazo alalazo merged commit cacfc3a into spack:develop Nov 29, 2019
@mwkrentel mwkrentel mentioned this pull request Jul 3, 2020
Closed
4 tasks
@ChristianTackeGSI ChristianTackeGSI mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

@adamjstewart adamjstewart adamjstewart approved these changes

@becker33 becker33 Awaiting requested review from becker33

Assignees

No one assigned

Labels

external-packages perl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

External perl breaks $PATH in build_env external perl from /usr breaks build dependencies

4 participants

@scheibelp @adamjstewart @mwkrentel @alalazo