Skip to content

cmake: add support for xlf and ninja#13796

Merged
chuckatkins merged 1 commit intodevelopfrom
hotfix/cmake
Nov 26, 2019
Merged

cmake: add support for xlf and ninja#13796
chuckatkins merged 1 commit intodevelopfrom
hotfix/cmake

Conversation

@junghans
Copy link
Copy Markdown
Contributor

@junghans junghans requested a review from chuckatkins November 19, 2019 23:28
@chuckatkins
Copy link
Copy Markdown

chuckatkins commented Nov 20, 2019

Since this is still an active MR, I'd prefer to wait until it's actually merged upstream. Specifying the patch this way will fail the checksum if the MR has any changes before getting merged. I get not wanting to wait long on it though. I'll follow up to make sure it's resolved and merged upstream ASAP if you can hold out a few days. In the meantime can you make do with the makefile generator until this is resolved upstream and we can pull it back down here?

@junghans
Copy link
Copy Markdown
Contributor Author

Since this is still an active MR, I'd prefer to wait until it's actually merged upstream. Specifying the patch this way will fail the checksum if the MR has any changes before getting merged. I get not wanting to wait long on it though. I'll follow up to make sure it's resolved and merged upstream ASAP if you can hold out a few days. In the meantime can you make do with the makefile generator until this is resolved upstream and we can pull it back down here?

We can wait a couple more days, no problem. The makefile generator is just 3x times slower due to the lack of parallelization.

@junghans
Copy link
Copy Markdown
Contributor Author

Updated.

Copy link
Copy Markdown

@chuckatkins chuckatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appropriate fix has now been merged upstream and updated here. Looks good to me.

@chuckatkins chuckatkins merged commit 7d3d03d into develop Nov 26, 2019
@junghans junghans deleted the hotfix/cmake branch November 27, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants