Skip to content

new package: py-arrow#13575

Merged
adamjstewart merged 6 commits intospack:developfrom
healther:PR/arrow
Nov 26, 2019
Merged

new package: py-arrow#13575
adamjstewart merged 6 commits intospack:developfrom
healther:PR/arrow

Conversation

@healther
Copy link
Copy Markdown
Contributor

@healther healther commented Nov 4, 2019

depends on #13567 #13570 #13571

@healther healther mentioned this pull request Nov 4, 2019
@healther
Copy link
Copy Markdown
Contributor Author

healther commented Nov 5, 2019

general question: How do you get/test the dependencies? Do you have spack stage it? I tend to go to the github pages and look online. The disadvantage there is that in most cases some dependencies are stripped prior to pypi-publication.. I would really love spack to be able to do the parsing directly for me

sidenode: Should the PythonPackage template contain the

depends_on('python@2.7:2.8,3.3:', type=('build', 'run'))

in the same way it currently contains setuptools and py-foo?

@adamjstewart
Copy link
Copy Markdown
Member

@healther
Copy link
Copy Markdown
Contributor Author

healther commented Nov 5, 2019

See https://spack.readthedocs.io/en/latest/build_systems/pythonpackage.html#python-dependencies

Today I learned... Thanks, I should probably have read that some time ago... :)

But I was also asking on a more manual level: Do you spack stage the packages? Do you manually download and extract the sources? Do you inspect setup.py manually or do you have a script?

@adamjstewart
Copy link
Copy Markdown
Member

But I was also asking on a more manual level: Do you spack stage the packages? Do you manually download and extract the sources? Do you inspect setup.py manually or do you have a script?

No, yes, yes. I download the latest tarball, extract it, and manually inspect the setup.py and/or setup.cfg for every package.

It's pretty hard to script when it's in the setup.py file. Part of the reason setuptools switched to storing the metadata in setup.cfg is to make it easier for package managers like us to automate this dependency finding. At some point, we should make something to manually parse setup.cfg at least.

@healther
Copy link
Copy Markdown
Contributor Author

healther commented Nov 6, 2019

dependencies are merged

@adamjstewart adamjstewart merged commit 7764fd0 into spack:develop Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants