Mesa should depend_on('glproto')#11360
Conversation
The mesa package refers to `GL/glproto.h`. On systems that don't have the OS packages installed, this leads to failures during the build [e.g. this comment in 01482](spack#10482 (comment)). This fixes it. Tested on a minimally provisioned CentOS 7.
|
FWIW, using the current develop branch and trying to build mesa w/out OpenGL support, e.g.: fails with (from the spack-build.out): So I'm not sure how to go about testing the need to parameterize the dependency. That said, this version of the dependency that's parameterized on OpenGL support also fixes @odoublewen's issue. diff --git a/var/spack/repos/builtin/packages/mesa/package.py b/var/spack/repos/builtin/packages/mesa/package.py
index 3ddf1bead..717f2aa53 100644
--- a/var/spack/repos/builtin/packages/mesa/package.py
+++ b/var/spack/repos/builtin/packages/mesa/package.py
@@ -33,7 +33,7 @@ class Mesa(MesonPackage):
depends_on('libxml2')
depends_on('zlib')
depends_on('expat')
- depends_on('glproto')
+ depends_on('glproto', when='+opengl')
# Internal options
variant('llvm', default=True, description="Enable LLVM.")I'd be happy to do it this way too.... |
|
ps. I think that Spack members(committers?) can push to this branch. I'd be happy if they did in the name of simple timely merges. |
|
Good catch! I believe this can actually be gated on +glx and made a build-only dep |
|
It doesn't seem to work as a build-only dependency, which is weird since it only installs headers. Making it |
|
I believe the build-only error is a mesa bug. I'm shepherding a fix upstream right now and I'll try it as a patch: |
|
@hartzell The build-only dep should work now with the associated patch. I'll merge the patch into upstream mesa as soon as someone takes a look at it there. |
|
@opadron could you also test building this in a minimal bare bones container |
|
This works for me with @chuckatkins patch. Lets get this etc, etc... |
|
I just finished the merge in upstream mesa so the problem should be limited to the 19.0.x releases and be included in upcoming 19.1 release. |
|
ping |
|
@hartzell, @chuckatkins and I agree that this is ready for merge. The only hangup is the failing tests on Travis. We think those are just transient issues, and hope to confirm as much by restarting their tests. We'll be ready to merge once we can get Travis to come back green. |
|
It looks like one of the travis builds timed out so I just did a dummy force push witt no changes to re-trigger the ci. |
This should be ready to go, see conversation for details.
ToDo:
openglvariant, but would appreciate guidance from someone more familiar with that world.The mesa package refers to
GL/glproto.h. On systems that don't have the OS packages installed, this leads to failures during the build e.g. this comment in 01482.This fixes it. Tested on a minimally provisioned CentOS 7.
@opadron, can you check it on your systems (I'm using the same base system that @odoublewen is, but I'm sure he'll test it too...).