Skip to content

Buildcache updates: Resubmit of #10287 #10756

Merged
gartung merged 2 commits intospack:developfrom
gartung:buildcache-placeholder-fix
Mar 1, 2019
Merged

Buildcache updates: Resubmit of #10287 #10756
gartung merged 2 commits intospack:developfrom
gartung:buildcache-placeholder-fix

Conversation

@gartung
Copy link
Copy Markdown
Member

@gartung gartung commented Feb 28, 2019

Resubmit of #10287
pending merge of #9199 and rebasing

@gartung gartung requested a review from scheibelp February 28, 2019 16:22
@gartung gartung force-pushed the buildcache-placeholder-fix branch 2 times, most recently from ad4aef4 to 24fa7ea Compare February 28, 2019 22:10
…unctions introduced in

spack#9199

Instead of replacing rpaths with placeholder and then checking strings, make use of the functions
relocate.is_recocatable and relocate.is_file_relocatable to decide if a package needs the allow-root option.

This fixes a problem where the placeholder path was not in the first rpath entry. This was seen in c++ libraries and binaries because the compiler was outside the spack install base path and always appears first in the rpath.

Instead of checking the first rpath entry, all rpaths have the placeholder path and the old install path (if it exists) replaced with the new install path.
@gartung gartung force-pushed the buildcache-placeholder-fix branch from 24fa7ea to 2dcf954 Compare March 1, 2019 02:34
@gartung gartung merged commit 1d4289a into spack:develop Mar 1, 2019
@gartung gartung deleted the buildcache-placeholder-fix branch March 4, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant