Skip to content

py-configparser: bump version (v3.5.1, which fixes backports namespaces issues)#10433

Merged
scheibelp merged 1 commit intospack:developfrom
hartzell:update-configparser
Jan 29, 2019
Merged

py-configparser: bump version (v3.5.1, which fixes backports namespaces issues)#10433
scheibelp merged 1 commit intospack:developfrom
hartzell:update-configparser

Conversation

@hartzell
Copy link
Copy Markdown
Contributor

This release includes a fix to clean up how configparser used namespaces.

I can now install py-flake8, load the resulting py-flake8 module, and have a working flake8 command (this was the failure case in #8343).

Chain of details starts here: jaraco/configparser#22

Closes #8343, #7370

FYI: @healther

This release includes a fix to clean up how configparser used namespaces.

I can now install `py-flake8`, load the resulting `py-flake8` module,
and have a working `flake8` command (this was the failure case in

Chain of details starts here:
jaraco/configparser#22

Closes spack#8343, spack#7370
@hartzell hartzell changed the title Add configparser v3.5.1, fixes backports mess Add configparser v3.5.1, which fixes backports namespaces issues Jan 24, 2019
Copy link
Copy Markdown
Contributor

@healther healther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here the version is 3.6.0, which one is the correct one?

@hartzell
Copy link
Copy Markdown
Contributor Author

I don't see an actual 3.6.0 release. I think that he backed out a 3.6.0 release and instead made a 3.5.1 release. See this commit

It looks like perhaps the previous maintainer had set up for a 3.6.0 or ....

@hartzell
Copy link
Copy Markdown
Contributor Author

Yeah, if you look at the "configparser network graph" you see that when he pulled in my patch from the old repository it included a step from 3.5.0 to 3.6.0. That was probably my guessing that this was a big enough change to warrant a minor number bump. He then overrode that and made it a minor version number bump instead. The newest release is 3.5.1.

@hartzell hartzell requested a review from adamjstewart January 25, 2019 19:36
@hartzell hartzell changed the title Add configparser v3.5.1, which fixes backports namespaces issues py-configparser: bump version (v3.5.1, which fixes backports namespaces issues) Jan 26, 2019
@hartzell
Copy link
Copy Markdown
Contributor Author

PING

@scheibelp
Copy link
Copy Markdown
Member

I can see this fixing #8343, but #7370 is to address general issues with handling of the backports namespace (which involves several packages), so I'm not sure why this would close it. Otherwise this seems good.

@scheibelp
Copy link
Copy Markdown
Member

This also appears to close #4155

So in all:

Fixes #8343 #4154
Closes #4155

Do you agree with that?

@hartzell
Copy link
Copy Markdown
Contributor Author

Anything I can do to get this merged?

@scheibelp
Copy link
Copy Markdown
Member

Anything I can do to get this merged?

I should have been clear: I was looking for a response to #10433 (comment). If you agree, I'll merge it.

@hartzell
Copy link
Copy Markdown
Contributor Author

Ah rats, forgot to update the browser window before posting that last cry for attention. Didn't see your two recent comments. Apologies!

I believe that it also closes #7370, the general problem was that all but one of the backports packages were using "pkgutil-style" namespacing, and/but configparser was uing "pkg_resource-style". A namespace needs to be one style or another.

The problem isn't having multiple namespace packages loaded, it's a clash of namespace styles (Thank Goodness(tm) there's only one way to do it in Python... 😱)

As I mentioned in the configparser PR:

The backports package established the backports namespace as pkgutil-style and other backports packages have followed its lead.

configparser using the pkg_resource-style has caused many problems, see e.g. configparser issue #17.

Now that configparser is updated, the backports namespace ought to be namespace problem free.

@scheibelp scheibelp merged commit f878c0c into spack:develop Jan 29, 2019
@scheibelp
Copy link
Copy Markdown
Member

That makes sense. Thanks for chasing it down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake8 command fails with: ImportError: No module named backports.configparser

3 participants