Steps to reproduce
spack.rewiring.rewire_node runs relocation code copied from binary_distribution.py, but doesn't contain later changes to the latter.
In particular codesign is not run on patched binaries, so they will not run on macos.
It should be refactored to use a common code path, so that it won't bit-rot again.
Information on your system
- Spack: 0.24.0.dev0 (b78c517)
- Python: 3.11.4
- Platform: darwin-sequoia-m1
Steps to reproduce
spack.rewiring.rewire_noderuns relocation code copied frombinary_distribution.py, but doesn't contain later changes to the latter.In particular
codesignis not run on patched binaries, so they will not run on macos.It should be refactored to use a common code path, so that it won't bit-rot again.
Information on your system