Skip to content

Enforce consistency with variant naming #15239

@sethrj

Description

@sethrj

I was surprised by a new variant name in OpenBLAS being mixed case (#14876), since I thought variants were strictly [a-z0-9-]+. A grep of builtin/packages/*/package.py shows a number of inconsistencies:

  • That new consistentFPCSR variant is the only variant in any package to have mixed case
  • The only other variants to have upper case are X, X11, and a variant K in the eem package
  • X, X11, x, and x11 are all variants meaning "require the libx11 package"
  • Most variants use underscores for separators if at all, but some use hyphens
  • There are surely gobs more.

Questions:

  1. Is there a point at which we unify these variant names?
  2. Is there documentation for best practices? (see Document Best Practices for Variant Naming #557 but a quick check in the packaging guide and packaging creation tutorial revealed nothing)
  3. How can we prevent new odd cases from creeping in during MRs?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions