llvm, mesa: update target comparison semantics (#12914)

mdorier · tgamblin · commit e6cae978b801 · 2019-09-25T16:41:02.000-07:00
* llvm: fixed issues with syntax and formatting
  * use spec.architecture.target.family
  * use spec.target instead of spec.architecture.target
* mesa: use == instead of __contains__
diff --git a/var/spack/repos/builtin/packages/llvm/package.py b/var/spack/repos/builtin/packages/llvm/package.py
@@ -683,16 +683,19 @@ def cmake_args(self):
                 # hence the test to see if the version starts with "flang".
                 targets.append('CppBackend')
 
-            if 'x86' in spec.architecture.target.lower():
+            if spec.target.family == 'x86' or spec.target.family == 'x86_64':
                 targets.append('X86')
-            elif 'arm' in spec.architecture.target.lower():
+            elif spec.target.family == 'arm':
                 targets.append('ARM')
-            elif 'aarch64' in spec.architecture.target.lower():
+            elif spec.target.family == 'aarch64':
                 targets.append('AArch64')
-            elif 'sparc' in spec.architecture.target.lower():
+            elif (spec.target.family == 'sparc' or
+                  spec.target.family == 'sparc64'):
                 targets.append('Sparc')
-            elif ('ppc' in spec.architecture.target.lower() or
-                  'power' in spec.architecture.target.lower()):
+            elif (spec.target.family == 'ppc64' or
+                  spec.target.family == 'ppc64le' or
+                  spec.target.family == 'ppc' or
+                  spec.target.family == 'ppcle'):
                 targets.append('PowerPC')
 
             cmake_args.append(
diff --git a/var/spack/repos/builtin/packages/mesa/package.py b/var/spack/repos/builtin/packages/mesa/package.py
@@ -101,7 +101,7 @@ def configure_args(self):
         args_gallium_drivers = ['swrast']
         args_dri_drivers = []
 
-        if 'arm' in spec.architecture.target.lower():
+        if spec.target.family == 'arm':
             args.append('--disable-libunwind')
 
         num_frontends = 0
