Skip to content

Added TransactionalTree::generate_id()#1146

Merged
spacejam merged 1 commit intospacejam:masterfrom
pantonov:tt-genid
Aug 22, 2020
Merged

Added TransactionalTree::generate_id()#1146
spacejam merged 1 commit intospacejam:masterfrom
pantonov:tt-genid

Conversation

@pantonov
Copy link
Copy Markdown
Contributor

Added TransactionalTree::generate_id()

  • renamed PageCache::generate_id() to PageCache::generate_id_inner()
  • moved concurrency lock from PageCache::generate_id_inner() to Context::generate_id()
  • TransactionalTree::generate_id() uses PageCache::generate_id_inner() with lock obtained in stage(), thus avoiding deadlock
    and providing fix for Calling generate_id() in a transaction blocks #1139

@spacejam
Copy link
Copy Markdown
Owner

looks good! thanks :)

@spacejam spacejam merged commit c8578a0 into spacejam:master Aug 22, 2020
@spacejam
Copy link
Copy Markdown
Owner

released sled 0.34.3 that includes your change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants