Skip to content

dhcpv4: fixes#19

Merged
soypat merged 2 commits intosoypat:mainfrom
egonelbre:fix-dhcp
Jan 13, 2026
Merged

dhcpv4: fixes#19
soypat merged 2 commits intosoypat:mainfrom
egonelbre:fix-dhcp

Conversation

@egonelbre
Copy link
Copy Markdown
Contributor

  • condition flipped in Encapsulate
  • check for correct bounds in ForEachOption
  • getMessageType didn't check for opt
  • reset backing buffers

* condition flipped in Encapsulate
* check for correct bounds in ForEachOption
* getMessageType didn't check for opt
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a5af5b5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage        ?   38.72%           
=======================================
  Files           ?       68           
  Lines           ?     6853           
  Branches        ?        0           
=======================================
  Hits            ?     2654           
  Misses          ?     3817           
  Partials        ?      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soypat
Copy link
Copy Markdown
Owner

soypat commented Jan 13, 2026

Yet again, very neat finds and improvements.

@soypat soypat merged commit 3d5999a into soypat:main Jan 13, 2026
3 checks passed
@soypat
Copy link
Copy Markdown
Owner

soypat commented Jan 13, 2026

@egonelbre Thank you kindly for dedicating time to fixing this repo up! 💗

@egonelbre egonelbre deleted the fix-dhcp branch January 13, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants