matchiter: capture metric NgramLookups#608
Merged
Merged
Conversation
gl-srgr
reviewed
Jun 29, 2023
|
|
||
| func TestAndSearch(t *testing.T) { | ||
| b := testIndexBuilder(t, nil, | ||
| func TestSearchStats(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Is there a simple way to test noMatchTree's new stats? Or maybe that is handled in another test case?
Member
Author
There was a problem hiding this comment.
It is tested in the test case I added "one-trigram-pruned"
gl-srgr
approved these changes
Jun 29, 2023
gl-srgr
left a comment
Contributor
There was a problem hiding this comment.
one comment but otherwise lgtm
This instruments our matchiter code to track how often is calls Get on the underlying ngram index. We have some queries on long strings which are going much slower than expected and we suspect it is related to the work done here. This change requires a few moving pieces: - Adding the int to Stats - Instrumenting places we log/emit Stats - grpc support - capturing this work in matchiter code - updating tests to ensure correctness The last two points are the meat of this commit, while the rest was mechanical work. I reworked the TestAndSearch since into TestSearchStats since it was the only test which had useful assertions on Stats. I was surprised to see how high the ngram lookup values were for such simple queries. This makes me more confident in improving our performance here. Test Plan: go test
4634e4c to
8852e6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This instruments our matchiter code to track how often is calls Get on the underlying ngram index. We have some queries on long strings which are going much slower than expected and we suspect it is related to the work done here.
This change requires a few moving pieces:
The last two points are the meat of this commit, while the rest was mechanical work. I reworked the TestAndSearch since into TestSearchStats since it was the only test which had useful assertions on Stats.
I was surprised to see how high the ngram lookup values were for such simple queries. This makes me more confident in improving our performance here.
Test Plan: go test
Depends on #607
Part of https://github.com/sourcegraph/sourcegraph/issues/54950