Skip to content

indexserver: remove unused GetRepoRank#604

Merged
keegancsmith merged 1 commit into
mainfrom
k/rm-repo-rank
Jun 23, 2023
Merged

indexserver: remove unused GetRepoRank#604
keegancsmith merged 1 commit into
mainfrom
k/rm-repo-rank

Conversation

@keegancsmith

Copy link
Copy Markdown
Member

I think this is our older ranking stuff.

Test Plan: go test

I think this is our older ranking stuff.

Test Plan: go test
@keegancsmith keegancsmith requested a review from a team June 23, 2023 07:43
@stefanhengl

Copy link
Copy Markdown
Member

Is that a backward compatible change in the sense of gRPC?

@keegancsmith

Copy link
Copy Markdown
Member Author

I think this is declaring something that is exported on the sourcegraph-frontend's grpc server. IE there is probably a corresponding PR on the sg repo to remove the endpoint. So this is safe. For the server side removal it will also be safe because no one is calling it.

@stefanhengl

Copy link
Copy Markdown
Member

@stefanhengl

Copy link
Copy Markdown
Member

Anyway, it will probably work ;-)

@keegancsmith

Copy link
Copy Markdown
Member Author

It is backwards incompatible in that sense, but it only really counts if a client is trying to call it.

@keegancsmith keegancsmith merged commit 1686b50 into main Jun 23, 2023
@keegancsmith keegancsmith deleted the k/rm-repo-rank branch June 23, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants