indexserver: remove unused GetRepoRank#604
Merged
Merged
Conversation
I think this is our older ranking stuff. Test Plan: go test
Member
|
Is that a backward compatible change in the sense of gRPC? |
Member
Author
|
I think this is declaring something that is exported on the sourcegraph-frontend's grpc server. IE there is probably a corresponding PR on the sg repo to remove the endpoint. So this is safe. For the server side removal it will also be safe because no one is calling it. |
Member
|
I meant backward compatible in this sense |
Member
|
Anyway, it will probably work ;-) |
stefanhengl
approved these changes
Jun 23, 2023
Member
Author
|
It is backwards incompatible in that sense, but it only really counts if a client is trying to call it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is our older ranking stuff.
Test Plan: go test