Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sourcegraph/zoekt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 12ce07a298ae
Choose a base ref
...
head repository: sourcegraph/zoekt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ebb3ca24249d
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Jul 29, 2024

  1. Enabling numContextLines in non-json format (#796)

    @po3rin
    po3rin authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    04e7057 View commit details
    Browse the repository at this point in the history

  2. index: use a random sample of ngrams when limiting (#797) 

    The first bit of data I am getting back indicates this strategy of
limiting the number of ngrams we lookup isn't working. I am still
experimenting with different limits, but in the meantime it is easy to
implement a strategy which picks a random subset. This is so that the
first N ngrams of a query aren't the only ones being consulted.

Test Plan: ran all tests with the envvar set to 2. I expected tests that
assert on stats to fail, but everything else to pass. This was the case.

  SRC_EXPERIMENT_ITERATE_NGRAM_LOOKUP_LIMIT=2 go test ./...
    @keegancsmith
    keegancsmith authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    ebb3ca2 View commit details
    Browse the repository at this point in the history
Loading