gitindex: update remote.origin.url if clone already exists (#776)

keegancsmith · web-flow · commit 7c5b77843b4e · 2024-05-03T21:12:31.000+02:00
This is so that when authentication details change we correctly update
the CloneURL for repositories managed by our mirror commands.
diff --git a/gitindex/clone.go b/gitindex/clone.go
@@ -18,6 +18,7 @@ import (
 	"bytes"
 	"fmt"
 	"log"
+	"maps"
 	"os"
 	"os/exec"
 	"path/filepath"
@@ -60,7 +61,9 @@ func CloneRepo(destDir, name, cloneURL string, settings map[string]string) (stri
 
 	repoDest := filepath.Join(parent, filepath.Base(name)+".git")
 	if _, err := os.Lstat(repoDest); err == nil {
-		// Repository exists, ensure settings are in sync
+		// Repository exists, ensure settings are in sync including the clone URL
+		settings := maps.Clone(settings)
+		settings["remote.origin.url"] = cloneURL
 		if err := updateZoektGitConfig(repoDest, settings); err != nil {
 			return "", fmt.Errorf("failed to update repository settings: %w", err)
 		}
