Skip to content

RIDICULOUS: Set chown in workspace volume and create temp file#433

Closed
mrnugget wants to merge 1 commit into
mainfrom
erik-and-thorsten/stupid-fixes-part1
Closed

RIDICULOUS: Set chown in workspace volume and create temp file#433
mrnugget wants to merge 1 commit into
mainfrom
erik-and-thorsten/stupid-fixes-part1

Conversation

@mrnugget

Copy link
Copy Markdown
Contributor

No description provided.

@LawnGnome

LawnGnome commented Jan 20, 2021

Copy link
Copy Markdown
Contributor

OK, so I said I'd polish this off today in the sync. I was, of course, wildly optimistic, because I realised only this afternoon that there's another issue: if the user explicitly selects -workspace volume, all that UID detection code doesn't fire, because it's in the best workspace detector. 💥

So that I don't pollute this simple approach, I've opened #434, which builds on top of this PR, with an approach I explored. It may be more complicated than we want. Please provide feedback!

@LawnGnome

Copy link
Copy Markdown
Contributor

We ended up building on this in #434, so this is now moot.

@LawnGnome LawnGnome closed this Jan 22, 2021
@keegancsmith keegancsmith deleted the erik-and-thorsten/stupid-fixes-part1 branch November 11, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants